SERVER-118939 Add support for mozJS build compatibility for 8.0 backport#5
Merged
aditya8061 merged 3 commits intoFeb 5, 2026
Conversation
|
(Automated Close) Please do not file pull requests here, see https://firefox-source-docs.mozilla.org/contributing/how_to_submit_a_patch.html |
aveselova
requested changes
Feb 5, 2026
Collaborator
aveselova
left a comment
aveselova
left a comment
There was a problem hiding this comment.
I would suggest:
- pull spidermonkey-esr140.7-cpp-only into this branch to resolve conflict
- address the comments from https://mongodb.slack.com/archives/C0AC3909K63/p1770309732934739?thread_ts=1770222559.757719&cid=C0AC3909K63
- delete the entire
.githubdirectory as part of this PR (get rid of the git hook + README which doesn't apply)
Then we can review and merge this via this PR rather than in slack
leemaguire
approved these changes
Feb 5, 2026
aveselova
approved these changes
Feb 5, 2026
Collaborator
aveselova
left a comment
aveselova
left a comment
There was a problem hiding this comment.
Changes look good
Can you change the PR title to something that will make the commit message clearer, ex "Support older fmt version, delete github action, document explicit import"
Collaborator
|
Also let's make sure evergreen looks good on master and 8.0 before we merge this |
Collaborator
Author
|
Yes - I will trigger evergreen patch on master. Plan is to first merge it to master and then backport these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.